Swift: extract still unextracted entities from the 6.0.2 upgrade #19299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for new Swift entities introduced in version 6.0.2 by adding translation functions and updating tag mappings.
- Added two new expression translation functions: one for extracting function isolation and one for retrieving current context isolation.
- Updated tag mappings in SwiftTagTraits to replace placeholder void values with explicit tags.
Reviewed Changes
Copilot reviewed 24 out of 41 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| swift/extractor/translators/ExprTranslator.h | Declares new translation functions for handling isolation expressions. |
| swift/extractor/translators/ExprTranslator.cpp | Implements the new translation functions with appropriate label fetching. |
| swift/extractor/infra/SwiftTagTraits.h | Updates mappings for ActorIsolationErasureExpr, UnreachableExpr, ExtractFunctionIsolationExpr, and CurrentContextIsolationExpr using explicit tags. |
Files not reviewed (17)
- swift/downgrades/be2357fd0023261478871eff5df5c57df559aa3b/downgrade.ql: Language not supported
- swift/downgrades/be2357fd0023261478871eff5df5c57df559aa3b/upgrade.properties: Language not supported
- swift/ql/.generated.list: Language not supported
- swift/ql/.gitattributes: Language not supported
- swift/ql/lib/codeql/swift/controlflow/internal/ControlFlowGraphImpl.qll: Language not supported
- swift/ql/lib/codeql/swift/elements.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/ActorIsolationErasureExpr.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/CurrentContextIsolationExpr.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/ExtractFunctionIsolationExpr.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/UnreachableExpr.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/internal/ActorIsolationErasureExprConstructor.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/internal/ActorIsolationErasureExprImpl.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/internal/CurrentContextIsolationExprConstructor.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/internal/CurrentContextIsolationExprImpl.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/internal/ExtractFunctionIsolationExprConstructor.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/internal/ExtractFunctionIsolationExprImpl.qll: Language not supported
- swift/ql/lib/codeql/swift/elements/expr/internal/UnreachableExprConstructor.qll: Language not supported
Comments suppressed due to low confidence (2)
swift/extractor/translators/ExprTranslator.cpp:674
- The newly introduced translation functions for ExtractFunctionIsolationExpr and CurrentContextIsolationExpr do not have accompanying tests. Consider adding tests to verify that the correct labels are being fetched and that the entry objects are populated as expected.
codeql::ExtractFunctionIsolationExpr ExprTranslator::translateExtractFunctionIsolationExpr(const swift::ExtractFunctionIsolationExpr& expr) {
swift/extractor/infra/SwiftTagTraits.h:205
- With the updated mappings replacing the TODO placeholders, it would be beneficial to add tests ensuring that these tag values are correctly utilized during the extraction process.
MAP(swift::ExtractFunctionIsolationExpr, ExtractFunctionIsolationExprTag)
jketema
reviewed
Apr 14, 2025
jketema
reviewed
Apr 14, 2025
|
Looks like the DCA experiment failed? |
I think it's a DCA hiccup, I had a similar thing happenign on a Rust DCA. Tried the |
jketema
approved these changes
Apr 15, 2025
|
There was a -3 successfully extracted files on the first DCA run in the Dovve repo, but a rerun on that same repo has shown a +3 there, which indicates that number is flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were not added when a timeboxed effort to make Swift produce the new entity did not bear any fruit.